xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when

To: Tomas Racek <tracek@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when creating new script
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 31 Jul 2012 07:56:30 +1000
Cc: xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx
In-reply-to: <1343649811-13944-1-git-send-email-tracek@xxxxxxxxxx>
References: <1343649811-13944-1-git-send-email-tracek@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 30, 2012 at 02:03:31PM +0200, Tomas Racek wrote:
> 
> Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>
> ---
>  common.config |   26 ++++++++++++++------------
>  1 files changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/common.config b/common.config
> index 7bed1c5..b92c025 100644
> --- a/common.config
> +++ b/common.config
> @@ -201,9 +201,9 @@ known_hosts()
> 
>    #  Mandatory Config values.
>    MC=""
> -  [ -z "$EMAIL" ]          && MC="$MC EMAIL"
> -  [ -z "$TEST_DIR" ]       && MC="$MC TEST_DIR"
> -  [ -z "$TEST_DEV" ]       && MC="$MC TEST_DEV"
> +  [ -z "$EMAIL" ]                           && MC="$MC EMAIL"
> +  [ -z "$TEST_DIR" ] && [ "$iam" != "new" ] && MC="$MC TEST_DIR"
> +  [ -z "$TEST_DEV" ] && [ "$iam" != "new" ] && MC="$MC TEST_DEV"

Given that I'm currently in the process of killing $iam as I
rework the structure of xfstests, I really don't like the idea of
introducing new dependencies on it.

Also, I prefer to know that someone writing a new test is developing
it in a configured, working test environment. After all, you have to
test your new test as you write it... :p

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>