xfs
[Top] [All Lists]

Re: [PATCH 5/7] xfs: refactor xfs_ialloc_ag_select

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/7] xfs: refactor xfs_ialloc_ag_select
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 26 Jul 2012 12:53:01 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120704145616.185221770@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120704145444.863203951@xxxxxxxxxxxxxxxxxxxxxx> <20120704145616.185221770@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/04/12 09:54, Christoph Hellwig wrote:
Loop over the in-core perag structures and prefer using pagi_freecount over
going out to the AGI buffer where possible.

Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good

Not your fault, but the "longest" variable is complicated to understand.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>