xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: remove xfs_inactive_attrs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: remove xfs_inactive_attrs
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 26 Jul 2012 10:31:02 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20120704151443.421487431@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120704151328.928543446@xxxxxxxxxxxxxxxxxxxxxx> <20120704151443.421487431@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 07/04/2012 10:13 AM, Christoph Hellwig wrote:
Remove this helper as the code flow is a lot more obvious when it gets
merged into its only caller.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

---
 fs/xfs/xfs_vnodeops.c |   97 ++++++++++++++++++--------------------------------
 1 file changed, 36 insertions(+), 61 deletions(-)

I agree the code flows much better with this patch.  Looks good.

Reviewed-by:    Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>