Re: [PATCH 2/5] xfs: remove xfs_inactive

xfs

Re: [PATCH 2/5] xfs: remove xfs_inactive_attrs

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/5] xfs: remove xfs_inactive_attrs
From:	Rich Johnston <rjohnston@xxxxxxx>
Date:	Thu, 26 Jul 2012 10:31:02 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20120704151443.421487431@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120704151328.928543446@xxxxxxxxxxxxxxxxxxxxxx> <20120704151443.421487431@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 07/04/2012 10:13 AM, Christoph Hellwig wrote:

Remove this helper as the code flow is a lot more obvious when it gets
merged into its only caller.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

---
 fs/xfs/xfs_vnodeops.c |   97 ++++++++++++++++++--------------------------------
 1 file changed, 36 insertions(+), 61 deletions(-)

I agree the code flows much better with this patch.  Looks good.

Reviewed-by:    Rich Johnston <rjohnston@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/5] do not take the iolock in inode reclaim context, Christoph Hellwig [PATCH 4/5] xfs: avoid the iolock in xfs_free_eofblocks for evicted inodes, Christoph Hellwig Re: [PATCH 4/5] xfs: avoid the iolock in xfs_free_eofblocks for evicted inodes, Rich Johnston [PATCH 5/5] xfs: remove iolock lock classes, Christoph Hellwig Re: [PATCH 5/5] xfs: remove iolock lock classes, Rich Johnston [PATCH 2/5] xfs: remove xfs_inactive_attrs, Christoph Hellwig Re: [PATCH 2/5] xfs: remove xfs_inactive_attrs, Rich Johnston <= [PATCH 3/5] xfs: do not take the iolock in xfs_inactive, Christoph Hellwig Re: [PATCH 3/5] xfs: do not take the iolock in xfs_inactive, Rich Johnston [PATCH 1/5] xfs: clean up xfs_inactive, Christoph Hellwig Re: [PATCH 1/5] xfs: clean up xfs_inactive, Rich Johnston Re: [PATCH 0/5] do not take the iolock in inode reclaim context, Sage Weil Message not available Re: [PATCH 0/5] do not take the iolock in inode reclaim context, Sage Weil Re: [PATCH 0/5] do not take the iolock in inode reclaim context, Mark Tinguely Re: [PATCH 0/5] do not take the iolock in inode reclaim context, Rich Johnston

Previous by Date:	Re: [PATCH 1/5] xfs: clean up xfs_inactive, Rich Johnston
Next by Date:	Re: [PATCH 3/5] xfs: do not take the iolock in xfs_inactive, Rich Johnston
Previous by Thread:	[PATCH 2/5] xfs: remove xfs_inactive_attrs, Christoph Hellwig
Next by Thread:	[PATCH 3/5] xfs: do not take the iolock in xfs_inactive, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]