[Top] [All Lists]

Re: [PATCH 1/5] xfs: clean up xfs_inactive

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: clean up xfs_inactive
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 26 Jul 2012 10:30:56 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20120704151443.077344815@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120704151328.928543446@xxxxxxxxxxxxxxxxxxxxxx> <20120704151443.077344815@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 07/04/2012 10:13 AM, Christoph Hellwig wrote:
The code to reserve log space and join the inode to the transaction is
common for all cases, so don't duplicate it.  Also remove the trivial
xfs_inactive_symlink_local helper which can simply be opencode now.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

 fs/xfs/xfs_vnodeops.c |  171 ++++++++++++--------------------------------------
 1 file changed, 43 insertions(+), 128 deletions(-)

As stated this patch cleans up duplicate code and removed local helper function. Looks good.

Reviewed-by:    Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>