xfs
[Top] [All Lists]

[PATCH v5 1/4] xfs: Remove type argument from xfs_seek_data() and xfs_se

To: xfs@xxxxxxxxxxx
Subject: [PATCH v5 1/4] xfs: Remove type argument from xfs_seek_data() and xfs_seek_hole().
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Thu, 26 Jul 2012 16:55:35 +0800
Organization: Oracle
Reply-to: jeff.liu@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
The type is already indicated by the function naming explicitly, so this 
argument
can be omitted from those calls.

Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

---
 fs/xfs/xfs_file.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 9f7ec15..98642cf 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -969,8 +969,7 @@ xfs_vm_page_mkwrite(
 STATIC loff_t
 xfs_seek_data(
        struct file             *file,
-       loff_t                  start,
-       u32                     type)
+       loff_t                  start)
 {
        struct inode            *inode = file->f_mapping->host;
        struct xfs_inode        *ip = XFS_I(inode);
@@ -1036,8 +1035,7 @@ out_unlock:
 STATIC loff_t
 xfs_seek_hole(
        struct file             *file,
-       loff_t                  start,
-       u32                     type)
+       loff_t                  start)
 {
        struct inode            *inode = file->f_mapping->host;
        struct xfs_inode        *ip = XFS_I(inode);
@@ -1099,9 +1097,9 @@ xfs_file_llseek(
        case SEEK_SET:
                return generic_file_llseek(file, offset, origin);
        case SEEK_DATA:
-               return xfs_seek_data(file, offset, origin);
+               return xfs_seek_data(file, offset);
        case SEEK_HOLE:
-               return xfs_seek_hole(file, offset, origin);
+               return xfs_seek_hole(file, offset);
        default:
                return -EINVAL;
        }
-- 
1.7.4.1

<Prev in Thread] Current Thread [Next in Thread>