xfs
[Top] [All Lists]

[PATCH 06/10] xfstest: enable xfs_repair for large filesystem testing

To: xfs@xxxxxxxxxxx
Subject: [PATCH 06/10] xfstest: enable xfs_repair for large filesystem testing
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 26 Jul 2012 18:39:45 +1000
In-reply-to: <1343291989-14987-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1343291989-14987-1-git-send-email-david@xxxxxxxxxxxxx>
From: Dave Chinner <dchinner@xxxxxxxxxx>

Now that large filesystem testing does not play free space games to
fill the space without IO, we can enable xfs_repair when running in
this mode. xfs_repair has had it's scalability problems solved, too,
so this is a safe thing to do.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 common.rc |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/common.rc b/common.rc
index 7bb1133..a9252e0 100644
--- a/common.rc
+++ b/common.rc
@@ -1238,12 +1238,12 @@ _check_xfs_filesystem()
     extra_mount_options=""
     device=$1
     if [ "$2" != "none" ]; then
-               extra_log_options="-l$2"
+       extra_log_options="-l$2"
         extra_mount_options="-ologdev=$2"
     fi
 
     if [ "$3" != "none" ]; then
-               extra_rt_options="-r$3"
+       extra_rt_options="-r$3"
         extra_mount_options=$extra_mount_options" -ortdev=$3"
     fi
     extra_mount_options=$extra_mount_options" $MOUNT_OPTIONS"
@@ -1288,8 +1288,7 @@ _check_xfs_filesystem()
 
         ok=0
     fi
-    # repair doesn't scale massively at this stage, optionally skip it for now
-    [ "$LARGE_SCRATCH_DEV" = yes ] || \
+
     $XFS_REPAIR_PROG -n $extra_log_options $extra_rt_options $device 
>$tmp.repair 2>&1
     if [ $? -ne 0 ]
     then
-- 
1.7.10

<Prev in Thread] Current Thread [Next in Thread>