xfs
[Top] [All Lists]

Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten exte

To: Jie Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten extents
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 22 Jul 2012 02:28:30 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <500B8FAA.8030804@xxxxxxxxxx>
References: <50091696.4000903@xxxxxxxxxx> <5009A786.3080500@xxxxxxx> <500A4B24.40908@xxxxxxxxxx> <20120722045703.GA17235@xxxxxxxxxxxxx> <500B8FAA.8030804@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Jul 22, 2012 at 01:29:14PM +0800, Jie Liu wrote:
> Should we keep 285 unchanged and introduce a new test 28? which is
> dedicated to ensuring the refinements works as expected?
> I have added some new test cases to Mark's test program yesterday,
> looks it will grow even bigger if I can think out some other
> corner cases(will send them to Mark).

I think a separate case is better, as 285 just tests a basic correct
implementation, while this one tests the refinements.

<Prev in Thread] Current Thread [Next in Thread>