[Top] [All Lists]

Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten exte

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten extents
From: Jie Liu <jeff.liu@xxxxxxxxxx>
Date: Sun, 22 Jul 2012 13:29:14 +0800
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120722045703.GA17235@xxxxxxxxxxxxx>
References: <50091696.4000903@xxxxxxxxxx> <5009A786.3080500@xxxxxxx> <500A4B24.40908@xxxxxxxxxx> <20120722045703.GA17235@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
Hi Christoph,

On 07/22/2012 12:57 PM, Christoph Hellwig wrote:
On Sat, Jul 21, 2012 at 02:24:36PM +0800, Jie Liu wrote:

HOLE/DATA at 512K 786432 / 528384   <- undiscovered hole here
HOLE/DATA at 516K 786432 / 528384   <- okay, data but we should
                                        return next page as hole.
HOLE/DATA at 520K 532480 / 819200   <- hole is discovered because
                                       there is no trailing data
Oops! for xfs_seek_hole(), I should use min_t() to pre-claculate
offset before searching page cache.
Thanks for your prompt feedback.  I'll do some extra tests and post
the revised soon.
Yes, the above test cases should go into xfstests.
Should we keep 285 unchanged and introduce a new test 28? which is dedicated to ensuring the refinements works as expected? I have added some new test cases to Mark's test program yesterday, looks it will grow even bigger if I can think out some other
corner cases(will send them to Mark).


Thanks to both of you to spend all the effort on this feature.

<Prev in Thread] Current Thread [Next in Thread>