[Top] [All Lists]

Re: [PATCH v3] xfs: probe data buffer from page cache for unwritten exte

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v3] xfs: probe data buffer from page cache for unwritten extents
From: Jie Liu <jeff.liu@xxxxxxxxxx>
Date: Thu, 19 Jul 2012 22:39:45 +0800
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4FFB099C.6020809@xxxxxxx>
References: <4FF29C2C.2000407@xxxxxxxxxx> <4FFB099C.6020809@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
On 07/10/2012 12:41 AM, Mark Tinguely wrote:
On 07/03/12 02:15, Jeff Liu wrote:

This is v3 of the patch.

We can trigger BUG() in xfs_seek_data() if met two unwritten without data or hole extents at last version.
So making the extents map reading in loop could solve it.

Sorry, Am not yet try the repeated holes scenario according to Dave's comments as lack of X64 test env, still waiting for it ready. But this patch is already too long delayed, I have worked it out one weeks ago. So I'd like to post it because of it could handle repeated hole/unwritten extents well in a loop, and I also improved
xfstests:286 with those cases for the verification, will post it soon.

Tested by Mark, hit BUG() for continuous unwritten extents without data wrote.
* xfs_seek_data(), remove BUG() and having extents map search in loop.

suggested by Mark.
* xfs_has_unwritten_buffer(), use the input offset instead of bmap->br_startoff to
  calculate page index for data buffer probing.


Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>


Nice. Up to refining xfs_seek_hole()?
Thanks for the review.
Sorry for my late response, I missed you this email.
Sure, the refinement will be reflected in next post. :)


Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

xfs mailing list

<Prev in Thread] Current Thread [Next in Thread>