xfs
[Top] [All Lists]

Re: [PATCH v3] xfs: re-enable xfsaild idle mode and fix associated races

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v3] xfs: re-enable xfsaild idle mode and fix associated races
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 17 Jul 2012 03:00:00 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4FF1A74C.1070003@xxxxxxxxxx>
References: <1340880776-45730-1-git-send-email-bfoster@xxxxxxxxxx> <20120702070502.GA25568@xxxxxxxxxxxxx> <20120702082952.GR19223@dastard> <4FF1A74C.1070003@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 02, 2012 at 09:51:08AM -0400, Brian Foster wrote:
> Right... if we wanted to move this back into xfsaild_push(), the only
> way I can see doing that correctly is to move the task state logic down
> into that function as well, at which point the idle logic is now spread
> across two functions. :/
> 
> Considering this patch introduces an independent check for the idle
> logic from the timeout logic (i.e., we use xfs_ail_min() now instead of
> the general scan state of xfsaild_push()), I personally find the
> separation of idle from timeout to be a bit more clear, but of course
> I'll try to implement whatever is most agreeable...

Let's take the patch as-is for 3.6 as we have enough other work in that
area queued.  We can clean it up later if needed.

<Prev in Thread] Current Thread [Next in Thread>