xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: merge xfs_itobp into xfs_imap_to_bp

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: merge xfs_itobp into xfs_imap_to_bp
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 16 Jul 2012 12:34:46 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120703162122.GA16775@xxxxxxxxxxxxx>
References: <20120703162122.GA16775@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/03/12 11:21, Christoph Hellwig wrote:
All callers of xfs_imap_to_bp want the dinode pointer, so let's calculate it
inside xfs_imap_to_bp.  Once that is done xfs_itobp becomes a fairly pointless
wrapper which can be replaced with direct calls to xfs_imap_to_bp.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

---

Originally posted late March 2012. Still looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>