xfs
[Top] [All Lists]

Re: [PATCH] xfs: handle EOF correctly in xfs_vm_writepage

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: handle EOF correctly in xfs_vm_writepage
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 16 Jul 2012 11:05:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120703162000.GA13016@xxxxxxxxxxxxx>
References: <20120703162000.GA13016@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 07/03/12 11:20, Christoph Hellwig wrote:
We need to zero out part of a page which beyond EOF before setting uptodate,
otherwise, mapread or write will see non-zero data beyond EOF.

Based on the code in fs/buffer.c and the following ext4 commit:

   ext4: handle EOF correctly in ext4_bio_write_page()

And yes, I wish we had a good test case for it.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>

---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>