xfs
[Top] [All Lists]

Re: [PATCH 2/2 v2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_cal

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2 v2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 13 Jul 2012 14:12:43 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120713062410.GA24788@xxxxxxxxxxxxx>
References: <20120702100003.960640484@xxxxxxxxxxxxxxxxxxxxxx> <20120702100034.921366796@xxxxxxxxxxxxxxxxxxxxxx> <20120712230421.GE29979@xxxxxxx> <20120713061651.GA20909@xxxxxxxxxxxxx> <20120713062410.GA24788@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jul 13, 2012 at 02:24:10AM -0400, Christoph Hellwig wrote:
> xfs_bdstrat_cb only adds a check for a shutdown filesystem over
> xfs_buf_iorequest, but xfs_buf_iodone_callbacks just checked for a shut down
> filesystem a little earlier.  In addition the shutdown handling in
> xfs_bdstrat_cb is not very suitable for this caller.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This new version looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>