xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, for-linus, updated. for-linus

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, for-linus, updated. for-linus-Jun-21-2012-4-g1632dcc
From: xfs@xxxxxxxxxxx
Date: Fri, 13 Jul 2012 13:10:04 -0500
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, for-linus has been updated
  1632dcc xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
  40a9b79 xfs: prevent recursion in xfs_buf_iorequest
  aa29284 xfs: don't defer metadata allocation to the workqueue
  e3a746f5 xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near
      from  f7bdf03a99efc083608cd9c0c3e03abff311c79e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1632dcc93f55f9ab407b373da1957a727b1a7fe3
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:   Fri Jul 13 02:24:10 2012 -0400

    xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
    
    xfs_bdstrat_cb only adds a check for a shutdown filesystem over
    xfs_buf_iorequest, but xfs_buf_iodone_callbacks just checked for a shut down
    filesystem a little earlier.  In addition the shutdown handling in
    xfs_bdstrat_cb is not very suitable for this caller.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>

commit 40a9b7963df32e743c45d79a5f41445fe2476f15
Author: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:   Mon Jul 2 06:00:04 2012 -0400

    xfs: prevent recursion in xfs_buf_iorequest
    
    If the b_iodone handler is run in calling context in xfs_buf_iorequest we
    can run into a recursion where xfs_buf_iodone_callbacks keeps calling back
    into xfs_buf_iorequest because an I/O error happened, which keeps calling
    back into xfs_buf_iorequest.  This chain will usually not take long
    because the filesystem gets shut down because of log I/O errors, but even
    over a short time it can cause stack overflows if run on the same context.
    
    As a short term workaround make sure we always call the iodone handler in
    workqueue context.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>

commit aa292847b9fc6e187547110de833a7d3131bbddf
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Thu Jul 12 07:40:43 2012 +1000

    xfs: don't defer metadata allocation to the workqueue
    
    Almost all metadata allocations come from shallow stack usage
    situations. Avoid the overhead of switching the allocation to a
    workqueue as we are not in danger of running out of stack when
    making these allocations. Metadata allocations are already marked
    through the args that are passed down, so this is trivial to do.
    
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Reported-by: Mel Gorman <mgorman@xxxxxxx>
    Tested-by: Mel Gorman <mgorman@xxxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>

commit e3a746f5aab71f2dd0a83116772922fb37ae29d6
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Thu Jul 12 07:40:42 2012 +1000

    xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near
    
    The current cursor is reallocated when retrying the allocation, so
    the existing cursor needs to be destroyed in both the restart and
    the failure cases.
    
    Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
    Tested-by: Mike Snitzer <snitzer@xxxxxxxxxx>
    Signed-off-by: Ben Myers <bpm@xxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/xfs_alloc.c    |   19 +++++++++++++-----
 fs/xfs/xfs_buf.c      |   53 +++++++++++++++++++++----------------------------
 fs/xfs/xfs_buf.h      |    1 -
 fs/xfs/xfs_buf_item.c |    2 +-
 4 files changed, 38 insertions(+), 37 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, for-linus, updated. for-linus-Jun-21-2012-4-g1632dcc, xfs <=