xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callba

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 13 Jul 2012 02:16:51 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120712230421.GE29979@xxxxxxx>
References: <20120702100003.960640484@xxxxxxxxxxxxxxxxxxxxxx> <20120702100034.921366796@xxxxxxxxxxxxxxxxxxxxxx> <20120712230421.GE29979@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 12, 2012 at 06:04:21PM -0500, Ben Myers wrote:
> xfs/fs/xfs/xfs_buf.c:1062: error: static declaration of ???xfs_bdstrat_cb??? 
> follows non-static declaration
> xfs/fs/xfs/xfs_buf.h:183: error: previous declaration of ???xfs_bdstrat_cb??? 
> was here
> 
> CONFIG_XFS_DEBUG was not set.
> 
> I'm happy to have caught that before pulling this in.  Most of the time I am
> testing with CONFIG_XFS_DEBUG=y.  I'll fix it up.

The one in the header should just go away, that's why I moved
xfs_bwrite.

<Prev in Thread] Current Thread [Next in Thread>