xfs
[Top] [All Lists]

Re: [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where appl

To: Tony Luck <tony.luck@xxxxxxxxx>
Subject: Re: [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where applicable
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Thu, 12 Jul 2012 10:06:18 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, joshhunt00@xxxxxxxxx, axboe@xxxxxxxxx, rni@xxxxxxxxxx, vgoyal@xxxxxxxxxx, vwadekar@xxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, swhiteho@xxxxxxxxxx, bpm@xxxxxxx, elder@xxxxxxxxxx, xfs@xxxxxxxxxxx, marcel@xxxxxxxxxxxx, gustavo@xxxxxxxxxxx, johan.hedberg@xxxxxxxxx, linux-bluetooth@xxxxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=riLrDjjMdnz26RQdNBVJ18gHGY1MCbf6YhuNXdP8bc8=; b=M17p0zQtNbgNMM0vekIEoTAgZC8gqw8vgKif4JgO5dz/2CPw7Xzyin8w/ObcQ9l4vW 9H6nuG4iQaJZfzhv2PAm0FzsRVsQSdQukOMBZMW9tKJ/JCcVXtOvVDa0ti8hmWxT/11I h6JHPCxdqke1r64oCYlH3Mv32g9PGat+AKpnYdpOr6xkEAiOE5PfU6FheXglg25GLUZ1 eWdfU9vIn2cetJ6Vr9zLkBvxwHRVK9HgY5XzBhiYeyEKdT0rUvwX6kqvAF7ENsNnmA9K C7H5jVMrj8DO7IQABfeSramgnKp3r9Cn8BaLG4US9P18wdv3PMDc+VRWAxxN5iiykOoo FVwg==
In-reply-to: <CA+8MBbKtCODJxv0zQ2uL_wRE9U6F6tdOVwYSMv9=OQNLGzcVXQ@xxxxxxxxxxxxxx>
References: <1341859315-17759-1-git-send-email-tj@xxxxxxxxxx> <1341859315-17759-4-git-send-email-tj@xxxxxxxxxx> <CA+8MBbKtCODJxv0zQ2uL_wRE9U6F6tdOVwYSMv9=OQNLGzcVXQ@xxxxxxxxxxxxxx>
Sender: Tejun Heo <htejun@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hello, Tony.

On Tue, Jul 10, 2012 at 04:30:36PM -0700, Tony Luck wrote:
> On Mon, Jul 9, 2012 at 11:41 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > @@ -1234,7 +1235,7 @@ static void worker_enter_idle(struct worker *worker)
> >          */
> >         WARN_ON_ONCE(gcwq->trustee_state == TRUSTEE_DONE &&
> >                      pool->nr_workers == pool->nr_idle &&
> > -                    atomic_read(get_gcwq_nr_running(gcwq->cpu)));
> > +                    atomic_read(get_pool_nr_running(pool)));
> >  }
> 
> Just had this WARN_ON_ONCE trigger on ia64 booting next-20120710. I
> haven't bisected ... just noticed  that two patches in this series tinker
> with lines in this check. next-20120706 didn't generate the WARN.

Sorry about the delay.  The warning is spurious.  As now there are
multiple pools, nr_running check should be done before
pool->nr_workers check.  Will post fix soon.

Thank you.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>