| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 1/2] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 12 Jul 2012 07:40:42 +1000 |
| Cc: | bpm@xxxxxxx |
| In-reply-to: | <1342042843-1773-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1342042843-1773-1-git-send-email-david@xxxxxxxxxxxxx> |
From: Dave Chinner <dchinner@xxxxxxxxxx>
The current cursor is reallocated when retrying the allocation, so
the existing cursor needs to be destroyed in both the restart and
the failure cases.
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Tested-by: Mike Snitzer <snitzer@xxxxxxxxxx>
---
fs/xfs/xfs_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index 9d1aeb7..f654f51 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -1074,13 +1074,13 @@ restart:
* If we couldn't get anything, give up.
*/
if (bno_cur_lt == NULL && bno_cur_gt == NULL) {
+ xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR);
+
if (!forced++) {
trace_xfs_alloc_near_busy(args);
xfs_log_force(args->mp, XFS_LOG_SYNC);
goto restart;
}
-
- xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR);
trace_xfs_alloc_size_neither(args);
args->agbno = NULLAGBLOCK;
return 0;
--
1.7.10
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] xfs: don't defer metadata allocation to the workqueue, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 0/2] xfs: regression fixes for 3.5-rc7, Ben Myers |
| Previous by Thread: | [PATCH 2/2] xfs: don't defer metadata allocation to the workqueue, Dave Chinner |
| Next by Thread: | Re: [PATCH 1/2] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |