xfs
[Top] [All Lists]

Re: [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where appl

To: Tejun Heo <tj@xxxxxxxxxx>
Subject: Re: [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where applicable
From: Tony Luck <tony.luck@xxxxxxxxx>
Date: Tue, 10 Jul 2012 16:30:36 -0700
Cc: linux-kernel@xxxxxxxxxxxxxxx, torvalds@xxxxxxxxxxxxxxxxxxxx, joshhunt00@xxxxxxxxx, axboe@xxxxxxxxx, rni@xxxxxxxxxx, vgoyal@xxxxxxxxxx, vwadekar@xxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, swhiteho@xxxxxxxxxx, bpm@xxxxxxx, elder@xxxxxxxxxx, xfs@xxxxxxxxxxx, marcel@xxxxxxxxxxxx, gustavo@xxxxxxxxxxx, johan.hedberg@xxxxxxxxx, linux-bluetooth@xxxxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Y0R+Vgjq2C3ssmS1sB8HIqhIy29LFMQG4d7hU0+8dEk=; b=tzoDtLD6V7aofwdqWvr85KBsRQs8KE3aBMxTugoS3z+EoZw/DeG/UzHqUYKLpPEVHf f1/Ofu1qUiWtZJeCO9PApbhUJiQ13yVa2IeA536icVFi2Jtqk1lQXFVuRyp3Ve/YTuic R8XYZCu9DtFDC6RGm8bImz7B/lbZoVWo53O6yQ6guTT8lVv8SAC9VrL/bRAIfrBnJp8+ j0vV9XVQH26Uc+WWlNiEdc4cjpej1W/7PSY/rferOCsyfXMYzsO5wZV6u8rqUz4h07Hz T7kysngCcTW2T1b1J3bpLgCjlCgEZpYUDAp37mmOWsl6jRXs97KA/e1Pzy5UuFe5uivs /b5g==
In-reply-to: <1341859315-17759-4-git-send-email-tj@xxxxxxxxxx>
References: <1341859315-17759-1-git-send-email-tj@xxxxxxxxxx> <1341859315-17759-4-git-send-email-tj@xxxxxxxxxx>
Sender: tony.luck@xxxxxxxxx
On Mon, Jul 9, 2012 at 11:41 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> @@ -1234,7 +1235,7 @@ static void worker_enter_idle(struct worker *worker)
>          */
>         WARN_ON_ONCE(gcwq->trustee_state == TRUSTEE_DONE &&
>                      pool->nr_workers == pool->nr_idle &&
> -                    atomic_read(get_gcwq_nr_running(gcwq->cpu)));
> +                    atomic_read(get_pool_nr_running(pool)));
>  }

Just had this WARN_ON_ONCE trigger on ia64 booting next-20120710. I
haven't bisected ... just noticed  that two patches in this series tinker
with lines in this check. next-20120706 didn't generate the WARN.

-Tony

Mount-cache hash table entries: 1024
ACPI: Core revision 20120518
Boot processor id 0x0/0x0
------------[ cut here ]------------
WARNING: at kernel/workqueue.c:1217 worker_enter_idle+0x2d0/0x4a0()
Modules linked in:

Call Trace:
 [<a0000001000154e0>] show_stack+0x80/0xa0
                                sp=e0000040600f7c30 bsp=e0000040600f0da8
 [<a000000100d6e870>] dump_stack+0x30/0x50
                                sp=e0000040600f7e00 bsp=e0000040600f0d90
 [<a0000001000730a0>] warn_slowpath_common+0xc0/0x100
                                sp=e0000040600f7e00 bsp=e0000040600f0d50
 [<a000000100073120>] warn_slowpath_null+0x40/0x60
                                sp=e0000040600f7e00 bsp=e0000040600f0d28
 [<a0000001000aaad0>] worker_enter_idle+0x2d0/0x4a0
                                sp=e0000040600f7e00 bsp=e0000040600f0cf0
 [<a0000001000ad020>] worker_thread+0x4a0/0xbe0
                                sp=e0000040600f7e00 bsp=e0000040600f0c28
 [<a0000001000bda70>] kthread+0x110/0x140
                                sp=e0000040600f7e00 bsp=e0000040600f0be8
 [<a000000100013510>] kernel_thread_helper+0x30/0x60
                                sp=e0000040600f7e30 bsp=e0000040600f0bc0
 [<a00000010000a0c0>] start_kernel_thread+0x20/0x40
                                sp=e0000040600f7e30 bsp=e0000040600f0bc0
---[ end trace 9501f2472a75a227 ]---

<Prev in Thread] Current Thread [Next in Thread>