[Top] [All Lists]

[PATCH v3 0/2] block: improvements for discard alignment

To: linux-kernel@xxxxxxxxxxxxxxx
Subject: [PATCH v3 0/2] block: improvements for discard alignment
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Thu, 5 Jul 2012 18:01:42 +0200
Cc: snitzer@xxxxxxxxxx, david@xxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxx, martin.petersen@xxxxxxxxxx, axboe@xxxxxxxxx, vgoyal@xxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer; bh=advKrlKZsqFEI2SlSkgNF9hgpO0xM6YdMKanYYVFzfg=; b=0EvDMi2HKnBTr9iqkUl/DqyuKUljgxzNJiORSU3LydWP2qwIwXTdYnWByO4ms6oGXr sILfSQgMI+TGzpQcX2PCoNGRi6dXfsN5a4S05dgH0jZE1SXZ/aNRtl86Gpyqhw3Ev4WS qr4zztJfRxWjIliyFxRDcuWcvUem6/4vwgeU4El3ycMFvEORkj1vdXL48qq4FX/6VM05 ktmm8sEw2dyk8Mbrd6V65zXFaCnr7xKkUg5BBlFszPImlDfAaq9bUutd8kkKJktWzGkI 1TYB/ETHjWA4JWSSYxnLPsO/r6ElOR/hquHj5F/QZVYbLpj8pX7eHUHM/4kqq0B3RyEZ zpcQ==
Sender: Paolo Bonzini <paolo.bonzini@xxxxxxxxx>
When a disk has a large discard_granularity, discards are not split with
optimal alignment; the pessimization gets bigger as discard_granularity
and max_discard_sectors become closer.

Take the limit case of discard_granularity == max_discard_sectors == 64.
Then, if a request is submitted for 256 sectors 2..257 it will be split
like this: 2..65, 66..129, 130..193, 194..257.  None of these requests
is aligned, so in fact you might end up with no discarded logical blocks
at all.  With this patch, the split will be 2..63, 64..127, 128..191,
192..255, 256..257.  The patches also take the discard_alignment into

Patch 1 adjusts the computation of the granularity-adjusted
max_discard_sectors so that it prepares for the new code in patch 2,
which actually adjusts the split.

v2->v3: drop addition of queue/discard_alignment to sysfs, use
  correct alignment for partitions

Paolo Bonzini (2):
  block: reorganize rounding of max_discard_sectors
  block: split discard into aligned requests

 block/blk-lib.c        |   41 ++++++++++++++++++++++++++++-------------
 include/linux/blkdev.h |   10 ++++++++++
 2 files changed, 38 insertions(+), 13 deletions(-)

<Prev in Thread] Current Thread [Next in Thread>