Re: [PATCH] xfs: really fix the cursor leak in xfs_alloc_ag_vextent

xfs

Re: [PATCH] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 3 Jul 2012 12:06:34 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1341299489-29747-1-git-send-email-david@xxxxxxxxxxxxx>
References:	<1341299489-29747-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Tue, Jul 03, 2012 at 05:11:29PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The current cursor is reallocated when retrying the allocation, so
> the existing cursor needs to be destroyed in both the restart and
> the failure cases.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near, Dave Chinner Re: [PATCH] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks, Christoph Hellwig
Next by Date:	Re: [PATCH v3] xfs: re-enable xfsaild idle mode and fix associated races, Christoph Hellwig
Previous by Thread:	[PATCH] xfs: really fix the cursor leak in xfs_alloc_ag_vextent_near, Dave Chinner
Next by Thread:	[PATCH v3] xfs: probe data buffer from page cache for unwritten extents, Jeff Liu
Indexes:	[Date] [Thread] [Top] [All Lists]