xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callba

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 3 Jul 2012 12:05:31 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120703002857.GY19223@dastard>
References: <20120702100003.960640484@xxxxxxxxxxxxxxxxxxxxxx> <20120702100034.921366796@xxxxxxxxxxxxxxxxxxxxxx> <20120703002857.GY19223@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jul 03, 2012 at 10:28:57AM +1000, Dave Chinner wrote:
> On Mon, Jul 02, 2012 at 06:00:05AM -0400, Christoph Hellwig wrote:
> > xfs_bdstrat_cb only adds a check for a shutdown filesystem over 
> > xfs_buf_iorequest,
> > but xfs_buf_iodone_callbacks just checked for a shut down filesystem a 
> > little
> > earlier.  In addition the shutdown handling in xfs_bdstrat_cb is not very 
> > suitable
> > for this caller.
> 
> Makes sense - I have a patch locally that does this as part of a
> xfs_buf_iorequest(bp, blkno, length) conversion to get rid of
> XFS_BUF_SETADDR()....

Can you send these out ASAP?  I have another big batch of buffer error
handling changes for 3.6 I'm working on right now.

<Prev in Thread] Current Thread [Next in Thread>