xfs
[Top] [All Lists]

Re: [PATCH] xfstests: improve test 286 for repeated unwritten/hole exten

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfstests: improve test 286 for repeated unwritten/hole extents.
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 03 Jul 2012 23:39:10 +0800
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4FF30A89.9010800@xxxxxxx>
Organization: Oracle
References: <4FF29F94.6030702@xxxxxxxxxx> <4FF30A89.9010800@xxxxxxx>
Reply-to: jeff.liu@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
On 07/03/2012 11:06 PM, Mark Tinguely wrote:

> On 07/03/12 02:30, Jeff Liu wrote:
>> Hello,
>>
>> I'd like to enlarge the test coverage of 286 to includes file mapping
>> with repeated hole/unwritten/unwritten_without_data/data intersections.
>>
>> Those two new sub-tests could help verifying the current
>> seek_data/seek_hole improvements.
>>
>> Besides, I observed a weird thing at the diff of 286.full, look at the
>> the sparse file creation output,  there seems to be a significant
>> I/O degradation compare to the old test01/test02 IOPS results:
>>
>> -1 MiB, 256 ops; 0.0000 sec (1.242 GiB/sec and 325699.7455 ops/sec)
>> +1 MiB, 256 ops; 0.0000 sec (70.161 MiB/sec and 17961.1310 ops/sec)
>>
>> I run the test on same machine and same partition, I recalled the old
>> result is generated against around 3.4-rc2(not very sure), now is updated
>> to 3.5-rc4, does anyone hit that?
>>
>>
> 
> Quick feedback. I don't see any degradation.

Thanks for the verification.

> 
> OLD:  1 MiB, 256 ops; 0.0000 sec (484.027 MiB/sec and 123910.9390 ops/sec)
> THIS: 1 MiB, 256 ops; 0.0000 sec (494.560 MiB/sec and 126607.3195 ops/sec)
> 
> All the tests are very close to the unpatched results.
> 
>> Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
>>
>> ---
>>   286      |   87
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>   286.full |   82
>> +++++++++++++++++++++++++++++++++++----------------------
> 
> Please, drop the 286.full patch.

Ok, will re-post a little while.

Thanks,
-Jeff

> 
> --Mark Tinguely.
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>