| To: | Vivek Goyal <vgoyal@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment |
| From: | Paolo Bonzini <pbonzini@xxxxxxxxxx> |
| Date: | Tue, 03 Jul 2012 13:51:13 +0200 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, axboe@xxxxxxxxx, snitzer@xxxxxxxxxx, martin.petersen@xxxxxxxxxx, david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx, dm-devel@xxxxxxxxxx, hch@xxxxxx |
| In-reply-to: | <20120703023442.GB3586@xxxxxxxxxx> |
| References: | <1341235225-27551-1-git-send-email-pbonzini@xxxxxxxxxx> <1341235225-27551-2-git-send-email-pbonzini@xxxxxxxxxx> <20120703023442.GB3586@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Il 03/07/2012 04:34, Vivek Goyal ha scritto: >> > The next patches will actually use the alignment, expose it in sysfs >> > for ease of debugging. >> > > Don't we already have discard_alignment exported as device attribute. > > /sys/block/<dev>/discard_alignment Ah, interesting, I missed it completely. I guess it's because queue/ directories only exist for full disks, and the correct alignment varies for each partition. So this patch is unnecessary. Paolo |
| Previous by Date: | Re: [dm-devel] [PATCH v2 2/3] block: reorganize rounding of max_discard_sectors, Paolo Bonzini |
|---|---|
| Next by Date: | Re: [MMTests] IO metadata on XFS, Daniel Vetter |
| Previous by Thread: | Re: [PATCH v2 1/3] block: add sysfs entry for discard_alignment, Mike Snitzer |
| Next by Thread: | Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment, Vivek Goyal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |