xfs
[Top] [All Lists]

Re: xfs_btree_cur leak with 3.5-rc4

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: xfs_btree_cur leak with 3.5-rc4
From: Mike Snitzer <snitzer@xxxxxxxxxx>
Date: Tue, 3 Jul 2012 01:53:24 -0400
Cc: xfs@xxxxxxxxxxx, dm-devel@xxxxxxxxxx
In-reply-to: <20120703032136.GZ19223@dastard>
References: <20120702191412.GA3617@xxxxxxxxxx> <20120703002611.GW19223@dastard> <20120703012628.GA5710@xxxxxxxxxx> <20120703032136.GZ19223@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 02 2012 at 11:21pm -0400,
Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> On Mon, Jul 02, 2012 at 09:26:28PM -0400, Mike Snitzer wrote:
> > On Mon, Jul 02 2012 at  8:26pm -0400,
> > Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > 
> > > On Mon, Jul 02, 2012 at 03:14:12PM -0400, Mike Snitzer wrote:
> > > > I get kmemleak reports against XFS when I run the thinp-test-suite
> > > > against 3.5-rc4.  I didn't see any XFS leaks with 3.4.
> > > 
> > > Already fixed in 3.5-rc5:
> > > 
> > > 76d0953 xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near
> > 
> > Odd, I already have that fix (as it was included in 3.5-rc4).
> 
> I misread the git describe as saying it was included after -rc4. My
> mistake. That indicates that the above fix wasn't quite correct...
> 
> Try the patch below.

Looks good.  Thanks.

Tested-by: Mike Snitzer <snitzer@xxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>