xfs
[Top] [All Lists]

Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignme

To: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Subject: Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment
From: Vivek Goyal <vgoyal@xxxxxxxxxx>
Date: Mon, 2 Jul 2012 22:34:43 -0400
Cc: linux-kernel@xxxxxxxxxxxxxxx, axboe@xxxxxxxxx, snitzer@xxxxxxxxxx, martin.petersen@xxxxxxxxxx, david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx, dm-devel@xxxxxxxxxx, hch@xxxxxx
In-reply-to: <1341235225-27551-2-git-send-email-pbonzini@xxxxxxxxxx>
References: <1341235225-27551-1-git-send-email-pbonzini@xxxxxxxxxx> <1341235225-27551-2-git-send-email-pbonzini@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 02, 2012 at 03:20:23PM +0200, Paolo Bonzini wrote:
> The next patches will actually use the alignment, expose it in sysfs
> for ease of debugging.
> 

Don't we already have discard_alignment exported as device attribute.

/sys/block/<dev>/discard_alignment

Thanks
Vivek

> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---
>  block/blk-sysfs.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index aa41b47..95e919c 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -146,6 +146,11 @@ static ssize_t queue_io_opt_show(struct request_queue 
> *q, char *page)
>       return queue_var_show(queue_io_opt(q), page);
>  }
>  
> +static ssize_t queue_discard_alignment_show(struct request_queue *q, char 
> *page)
> +{
> +     return queue_var_show(q->limits.discard_alignment, page);
> +}
> +
>  static ssize_t queue_discard_granularity_show(struct request_queue *q, char 
> *page)
>  {
>       return queue_var_show(q->limits.discard_granularity, page);
> @@ -343,6 +348,11 @@ static struct queue_sysfs_entry queue_io_opt_entry = {
>       .show = queue_io_opt_show,
>  };
>  
> +static struct queue_sysfs_entry queue_discard_alignment_entry = {
> +     .attr = {.name = "discard_alignment", .mode = S_IRUGO },
> +     .show = queue_discard_alignment_show,
> +};
> +
>  static struct queue_sysfs_entry queue_discard_granularity_entry = {
>       .attr = {.name = "discard_granularity", .mode = S_IRUGO },
>       .show = queue_discard_granularity_show,
> @@ -403,6 +413,7 @@ static struct attribute *default_attrs[] = {
>       &queue_io_min_entry.attr,
>       &queue_io_opt_entry.attr,
>       &queue_discard_granularity_entry.attr,
> +     &queue_discard_alignment_entry.attr,
>       &queue_discard_max_entry.attr,
>       &queue_discard_zeroes_data_entry.attr,
>       &queue_nonrot_entry.attr,
> -- 
> 1.7.1
> 
> 
> --
> dm-devel mailing list
> dm-devel@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/dm-devel

<Prev in Thread] Current Thread [Next in Thread>