| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Jul 2012 10:28:57 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120702100034.921366796@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20120702100003.960640484@xxxxxxxxxxxxxxxxxxxxxx> <20120702100034.921366796@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Jul 02, 2012 at 06:00:05AM -0400, Christoph Hellwig wrote: > xfs_bdstrat_cb only adds a check for a shutdown filesystem over > xfs_buf_iorequest, > but xfs_buf_iodone_callbacks just checked for a shut down filesystem a little > earlier. In addition the shutdown handling in xfs_bdstrat_cb is not very > suitable > for this caller. Makes sense - I have a patch locally that does this as part of a xfs_buf_iorequest(bp, blkno, length) conversion to get rid of XFS_BUF_SETADDR().... > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 1/2] xfs: prevent recursion in xfs_buf_iorequest, Dave Chinner |
|---|---|
| Next by Date: | Re: xfs_btree_cur leak with 3.5-rc4, Mike Snitzer |
| Previous by Thread: | [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |