xfs
[Top] [All Lists]

Re: [PATCH] xfs: cleanup the mount options

To: Zach Brown <zab@xxxxxxxxx>
Subject: Re: [PATCH] xfs: cleanup the mount options
From: Wanlong Gao <gaowanlong@xxxxxxxxxxxxxx>
Date: Sat, 30 Jun 2012 00:37:08 +0800
Cc: Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx
In-reply-to: <4FEDD7E8.901@xxxxxxxxx>
Organization: Fujitsu
References: <1340816243-6177-1-git-send-email-gaowanlong@xxxxxxxxxxxxxx> <20120627174448.GA3278@xxxxxxxxxxxxx> <4FEBAB3B.6020707@xxxxxxxxxxxxxx> <20120628160156.GC29979@xxxxxxx> <4FEC8768.8000109@xxxxxxxxx> <4FECFE26.2040506@xxxxxxxxxxxxxx> <4FEDD7E8.901@xxxxxxxxx>
Reply-to: gaowanlong@xxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 06/30/2012 12:29 AM, Zach Brown wrote:
> 
>> If you know XFS code, you really needn't cscope lookups on these
>> easy enough mount options. Don't stick to cscope lookups all the time.
> 
> That's nonsense.  It has nothing to do with "knowing" the identifiers,
> it's about giving tools the ability to move to them quickly.
> 
> Ben stated his preference, I seconded it.  You have the data and can
> chose to ignore it.  Let's move on.
> 

OK, I can drop the xfs_*_opt macros in V2, and any comments about the
parse options? I'd like to see the comments about the rest parts.

Thanks,
Wanlong Gao

> - z
> 


<Prev in Thread] Current Thread [Next in Thread>