| To: | Zach Brown <zab@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: cleanup the mount options |
| From: | Wanlong Gao <gaowanlong@xxxxxxxxxxxxxx> |
| Date: | Fri, 29 Jun 2012 09:00:22 +0800 |
| Cc: | Ben Myers <bpm@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx |
| In-reply-to: | <4FEC8768.8000109@xxxxxxxxx> |
| Organization: | Fujitsu |
| References: | <1340816243-6177-1-git-send-email-gaowanlong@xxxxxxxxxxxxxx> <20120627174448.GA3278@xxxxxxxxxxxxx> <4FEBAB3B.6020707@xxxxxxxxxxxxxx> <20120628160156.GC29979@xxxxxxx> <4FEC8768.8000109@xxxxxxxxx> |
| Reply-to: | gaowanlong@xxxxxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 06/29/2012 12:33 AM, Zach Brown wrote: > >> It's not a strong objection from me, but I do have a preference for keeping >> the >> XFS_MOUNT_ prefix to retain context for cscope and grep. Maybe others feel >> differently. > > For what it's worth, I agree. It's really annoying to have cscope > lookups fail and have to go poking around for things manually. If you know XFS code, you really needn't cscope lookups on these easy enough mount options. Don't stick to cscope lookups all the time. Anyway, omit use xfs_*_opt can make code looks more clearly. Thanks, Wanlong Gao > > - z > |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: cleanup the mount options, Carlos Maiolino |
|---|---|
| Next by Date: | Re: XFS Kernel Panics in CentOS, Changliang Chen |
| Previous by Thread: | Re: [PATCH] xfs: cleanup the mount options, Carlos Maiolino |
| Next by Thread: | Re: [PATCH] xfs: cleanup the mount options, Zach Brown |
| Indexes: | [Date] [Thread] [Top] [All Lists] |