| To: | Wanlong Gao <gaowanlong@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: cleanup the mount options |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 27 Jun 2012 13:44:48 -0400 |
| Cc: | xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, bpm@xxxxxxx |
| In-reply-to: | <1340816243-6177-1-git-send-email-gaowanlong@xxxxxxxxxxxxxx> |
| References: | <1340816243-6177-1-git-send-email-gaowanlong@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 28, 2012 at 12:57:23AM +0800, Wanlong Gao wrote: > remove the mount options macro, use tokens instead. > Futher cleanup will use xfs_*_opt in xfs instead, > but it may be hard to be merged in one patch. Thanks a lot! I like the use of the option parse a lot, this has been long overdue. But is there any good reason to add the xfs_*_opt macros? They make reading and especially grepping the code a lot harder, so there better be a good reason for them. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfs: cleanup the mount options, Wanlong Gao |
|---|---|
| Next by Date: | Re: [PATCH] xfs: cleanup the mount options, Wanlong Gao |
| Previous by Thread: | [PATCH] xfs: cleanup the mount options, Wanlong Gao |
| Next by Thread: | Re: [PATCH] xfs: cleanup the mount options, Wanlong Gao |
| Indexes: | [Date] [Thread] [Top] [All Lists] |