xfs
[Top] [All Lists]

Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 26 Jun 2012 06:16:43 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1340355015-26250-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1340355015-26250-1-git-send-email-david@xxxxxxxxxxxxx> <1340355015-26250-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jun 22, 2012 at 06:50:15PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The buffer reading code in xfs_dir2_leaf_getdents is complex and difficult to
> follow due to the readahead and all the context is carries. it is also badly
> indented and so difficult to read. Factor it out into a separate function to
> make it easier to understand and optimise in future patches.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>