[Top] [All Lists]

Re: [regression] stack overflow in xfs_buf_iodone_callbacks

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [regression] stack overflow in xfs_buf_iodone_callbacks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 26 Jun 2012 03:51:47 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120626022011.GB19223@dastard>
References: <20120621091803.GB10673@dastard> <20120621163409.GA7897@xxxxxxxxxxxxx> <20120621232414.GD10673@dastard> <20120622164147.GA20617@xxxxxxxxxxxxx> <20120622233955.GY19223@dastard> <20120625090657.GA22726@xxxxxxxxxxxxx> <20120626022011.GB19223@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 26, 2012 at 12:20:11PM +1000, Dave Chinner wrote:
> We will very soon - CRC checks after reading for disk will be done
> after reads. The patch series I'm working on at the moment
> introduces sanity checks of buffers on read completion - it doesn't
> do CRC checks yet, but it moves all the checks we do on read
> completion into iodone callbacks, and when CRCs are introduced they
> will simply be slotted into those functions....

I'm tempted to move calling of b_iodone into the caller that gets
waken by the completion, as that would help to clean a lot of nasty
bits up, but that's still a bit out.

The whole area aound xfs_bdstrat_cb, xfsbdstrat and buffer error handling
is something that needs a fair amount of attention, and I plan to tackle
a lot of it for 3.6.

<Prev in Thread] Current Thread [Next in Thread>