Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized.

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 20 Jun 2012 03:05:46 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20120620070147.GH30705@dastard>
References:	<1339133914-11148-1-git-send-email-david@xxxxxxxxxxxxx> <1339133914-11148-6-git-send-email-david@xxxxxxxxxxxxx> <20120620063612.GB5467@xxxxxxxxxxxxx> <20120620070147.GH30705@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jun 20, 2012 at 05:01:47PM +1000, Dave Chinner wrote:
> On Wed, Jun 20, 2012 at 02:36:12AM -0400, Christoph Hellwig wrote:
> > I like this patch with two minor nitpicks below.  Given that it's a mostly
> > unrelated cleanup I'd also propagate it to the first patch in the
> > series.
> 
> it's not unrelated - it makes the multiple buffer support so much
> easier to implement it's not funny....

Well, not entirely unrelated, but defintively a separate cleanup that
helpers later on.  I usually try to have these first in the series.

> XFS_MAX_BLOCKSIZE is now needed xfs_buf_item.h, so rather than
> introduce a dependency on xfs_alloc_btree.h, I moved them to where
> the other limits are defined (i.e. xfs_types.h).

Ok.  Please add a short blurb on this to the commit message.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, (continued) Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Dave Chinner Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Ben Myers Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Dave Chinner Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Ben Myers Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Christoph Hellwig Re: [PATCH 2/9] xfs: convert internal buffer functions to pass maps, Dave Chinner [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized., Dave Chinner Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized., Christoph Hellwig Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized., Dave Chinner Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized., Christoph Hellwig <= [PATCH 4/9] xfs: add discontiguous buffer support to transactions, Dave Chinner Re: [PATCH 4/9] xfs: add discontiguous buffer support to transactions, Christoph Hellwig [PATCH 6/9] xfs: support discontiguous buffers in the xfs_buf_log_item, Dave Chinner Re: [PATCH 6/9] xfs: support discontiguous buffers in the xfs_buf_log_item, Christoph Hellwig [PATCH 7/9] xfs: use multiple irec xfs buf support in dabuf, Dave Chinner Re: [PATCH 7/9] xfs: use multiple irec xfs buf support in dabuf, Christoph Hellwig [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Dave Chinner Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Christoph Hellwig Re: [PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents, Dave Chinner [PATCH 8/9] xfs: remove struct xfs_dabuf and infrastructure, Dave Chinner

Previous by Date:	Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized., Dave Chinner
Next by Date:	Re: [PATCH 6/9] xfs: support discontiguous buffers in the xfs_buf_log_item, Christoph Hellwig
Previous by Thread:	Re: [PATCH 5/9] xfs: struct xfs_buf_log_format isn't variable sized., Dave Chinner
Next by Thread:	[PATCH 4/9] xfs: add discontiguous buffer support to transactions, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]