xfs
[Top] [All Lists]

Re: Ext4 and xfs problems in dm-thin on allocation and discard

To: Spelic <spelic@xxxxxxxxxxxxx>
Subject: Re: Ext4 and xfs problems in dm-thin on allocation and discard
From: Mike Snitzer <snitzer@xxxxxxxxxx>
Date: Tue, 19 Jun 2012 09:34:42 -0400
Cc: Lukáš Czerner <lczerner@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, device-mapper development <dm-devel@xxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <4FE062B3.7080702@xxxxxxxxxxxxx>
References: <4FDF9EBE.2030809@xxxxxxxxxxxxx> <20120619015745.GJ25389@dastard> <20120619031241.GA3884@xxxxxxxxxx> <alpine.LFD.2.00.1206190816440.2241@xxxxxxxxxxxxxxxxxxxxxxxxx> <4FE062B3.7080702@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 19 2012 at  7:29am -0400,
Spelic <spelic@xxxxxxxxxxxxx> wrote:

> On 06/19/12 08:32, Lukáš Czerner wrote:
> >
> >So do I understand correctly that even though the discard came
> >through and thinp took advantage of it it still returns EOPNOTSUPP ?
> >This seems rather suboptimal. IIRC there was a discussion to add an
> >option to enable/disable sending discard in thinp target down
> >to the device.
> 
> I'll ask this too...
> do I understand correctly that dm-thin returns EOPNOTSUPP to the
> filesystem layer even though it is using the discard to unmap
> blocks, and at that point XFS stops sending discards down there
> (while ext4 keeps sending them)?

Are you actually seeing that?  Or are you just seizing on Lukas'
misunderstanding?

> This looks like a bug of dm-thin to me. Discards are "supported" in
> such a scenario.
> 
> Do you have a patch for dm-thin so to prevent it sending EOPTNOTSUPP ?

thinp should _not_ be sending -EOPNOTSUPP unless 'ignore_discard' is
provided as a feature when loading thin-pool's DM  table.

<Prev in Thread] Current Thread [Next in Thread>