xfs
[Top] [All Lists]

Re: [PATCH 6/7] xfs: do not read the AGI buffer in xfs_dialloc until nes

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/7] xfs: do not read the AGI buffer in xfs_dialloc until nessecary
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 18 Jun 2012 12:30:04 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120605144836.472805881@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120605144647.051012936@xxxxxxxxxxxxxxxxxxxxxx> <20120605144836.472805881@xxxxxxxxxxxxxxxxxxxxxx>
Resent-date: Mon, 18 Jun 2012 13:26:25 +1000
Resent-from: Dave Chinner <david@xxxxxxxxxxxxx>
Resent-message-id: <20120618032625.GT19223@dastard>
Resent-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 05, 2012 at 10:46:53AM -0400, Christoph Hellwig wrote:
> Refactor the AG selection loop in xfs_dialloc to operate on the in-memory
> perag data as much as possible.  We only read the AGI buffer once we have
> selected an AG to allocate inodes now instead of for every AG considered.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks ok to me.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>