[Top] [All Lists]

Re: [PATCH 2/7] xfs: split xfs_dialloc

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/7] xfs: split xfs_dialloc
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 18 Jun 2012 11:46:54 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20120605144835.679206152@xxxxxxxxxxxxxxxxxxxxxx>
References: <20120605144647.051012936@xxxxxxxxxxxxxxxxxxxxxx> <20120605144835.679206152@xxxxxxxxxxxxxxxxxxxxxx>
Resent-date: Mon, 18 Jun 2012 13:24:28 +1000
Resent-from: Dave Chinner <david@xxxxxxxxxxxxx>
Resent-message-id: <20120618032428.GP19223@dastard>
Resent-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 05, 2012 at 10:46:49AM -0400, Christoph Hellwig wrote:
> Move the actual allocation once we have selected an allocation group into a
> separate helper, and make xfs_dialloc a wrapper around it.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

looks ok. One minor thing - convert all the typedefs in the in
xfs_dialloc() function header to struct xxx format while you are
touching this code...

Other than that, 

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>