xfs
[Top] [All Lists]

Re: [PATCH] mm: add gfp_mask parameter to vm_map_ram()

To: Minchan Kim <minchan@xxxxxxxxxx>
Subject: Re: [PATCH] mm: add gfp_mask parameter to vm_map_ram()
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Thu, 14 Jun 2012 11:21:32 +0900
Cc: Fengguang Wu <fengguang.wu@xxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linux Memory Management List <linux-mm@xxxxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=wQfR7XKawjmPG0CvyNKpjJjPuydtZKzgXVzOel3QOt8=; b=wrlNTQpfru6HxLcC2veC5Vmr+eRZSZpCuwfOq+YyUJaXTudG7jzONI03o8nSMAvRZ/ /5/3hRLFgMsW/nxuUAxMJMk96c/eTy8Q35DERv2Bt8jGPk2pbqsrf5+nvbflJ7H/qH77 v97MtqGolSplhkbIDvZEjCcnDf7pw0wzzTmVTdtKrghcPfA6Q6V+npm/rSVEsb6CTGxN LMEW3PJUGCSgzAeP5AsSMNPVbA0gw/qx4yHOhu6aNjnouojW8u1896h5P6YSH+kFy2qu 0lf/B7UeoBSJ0i/a8s8h8uDLShL0lLshvLYrjco0B8Sf3kM5pvBcxtr8yaTesvCQjps3 VriQ==
In-reply-to: <4FD94779.3030108@xxxxxxxxxx>
References: <20120612012134.GA7706@localhost> <20120613123932.GA1445@localhost> <20120614012026.GL3019@xxxxxxxxxxxxxxxx> <20120614014902.GB7289@localhost> <4FD94779.3030108@xxxxxxxxxx>
Sender: Tejun Heo <htejun@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hello, guys.

On Thu, Jun 14, 2012 at 11:07:53AM +0900, Minchan Kim wrote:
> It shouldn't work because vmap_page_range still can allocate
> GFP_KERNEL by pud_alloc in vmap_pud_range.  For it, I tried [1] but
> other mm guys want to add WARNING [2] so let's avoiding gfp context
> passing.
> 
> [1] https://lkml.org/lkml/2012/4/23/77
> [2] https://lkml.org/lkml/2012/5/2/340

Yeah, vmalloc area doesn't support !GFP_KERNEL allocations and as
Minchan said, changing this would require updating page table
allocation functions on all archs.  This is the same reason why percpu
allocator doesn't support !GFP_KERNEL allocations which in turn made
blk-throttle implement its own private percpu pool.

If xfs can't live without GFP_NOFS vmalloc allocations, either it has
to implement its own pool or maybe it's time to implement !GFP_KERNEL
allocs for vmalloc area.  I don't know.

Thanks.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>