[Top] [All Lists]

Re: [PATCH 2/2] xfs: add FALLOC_FL_ZERO_RANGE to fallocate

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: add FALLOC_FL_ZERO_RANGE to fallocate
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Wed, 13 Jun 2012 08:24:12 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sh/uJMMqE6G3qlOiO7Y/kwk+vw2n7IEuY1SMCvIu3oo=; b=geIjMHUKL/+dU3W34KaktTvPazrka4s+QHIZ38Hkuwo2Z4+ThLyhYTAlT+XEjLSus0 ts3kCj9xUjX/DKQTS4WXlDJjBV9jC51Kuw+c8FptwFi7hx9jrL0prssCQZ1QZTtwtuem EcbYQJflBXdOo7AHGMeOjwAjJYlkJHb572N+OSU+mT5f7erDixsoUCGdVAZE8d2+Mzg+ 0BzVpRt8Sd+zYEl+O14DsNjJcei/cKnXjkMb5zs0Zge5WE1WFRpjwQ1Cwe4Gtg5fgDc3 ioFRxszRIO6s6ZZL99HXQtIT002QpDnk93SOjqKXM77Uj4i+QcV3UUV/UQccxv7nHSql 66vQ==
In-reply-to: <20120613021610.GQ22848@dastard>
References: <1339515364-17374-1-git-send-email-pbonzini@xxxxxxxxxx> <1339515364-17374-3-git-send-email-pbonzini@xxxxxxxxxx> <20120613021610.GQ22848@dastard>
Sender: Paolo Bonzini <paolo.bonzini@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0
Il 13/06/2012 04:16, Dave Chinner ha scritto:
>> > +  BUG_ON((mode & FALLOC_FL_PUNCH_HOLE) && (mode & FALLOC_FL_ZERO_RANGE));
> Never put BUG_ON() or BUG() in XFS code that can return an error.
> Return EINVAL if we chose not to support it, and if it's really
> something we consider bad, emit a warning to syslog (i.e.
> xfs_warn()) and potentially add a ASSERT() case so that debug
> kernels will trip over it. Nobody should be panicing a production
> system just because a user supplied a set of incorrect syscall
> paramters....

I know, the BUG_ON() is because it is ruled out in VFS code.  Of course
if I remove that code, this will not be a BUG_ON() anymore.


<Prev in Thread] Current Thread [Next in Thread>