[Top] [All Lists]

Re: [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/2] Add FALLOC_FL_ZERO_RANGE to fallocate
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Wed, 13 Jun 2012 08:13:29 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20120613033052.GT22848@dastard>
References: <1339515364-17374-1-git-send-email-pbonzini@xxxxxxxxxx> <20120613013549.GO22848@dastard> <20120613033052.GT22848@dastard>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0
Il 13/06/2012 05:30, Dave Chinner ha scritto:
>> > 
>> > Also, a minor nit, but you should credit where this code has
>> > originated from in the commit messages, and describe the use case
>> > for requiring it. i.e. based on:
>> > 
>> > http://permalink.gmane.org/gmane.linux.file-systems/62449

Interesting, I didn't know this---I wrote the code from scratch.

I took the description from the man pages ("This operation is a fast
method of overwriting any from the range specified with zeros without
removing any blocks or having to write zeros to disk"), so perhaps those
will have to be patched as well.

> Oh, and you'll need to provide a new xfstests test based on 242 that
> uses the new fallocate interface, and to do that you'll also need to
> add support for the new fallocate function in xfs_io.

Sure.  Thanks for the hints, I'll submit a v2 (may take a while as I'll
leave for holiday soon).


<Prev in Thread] Current Thread [Next in Thread>