xfs
[Top] [All Lists]

Re: [PATCH 18/27] xfs: Convert to new freezing code

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 18/27] xfs: Convert to new freezing code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 12 Jun 2012 10:23:47 -0400
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, linux-fsdevel@xxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
In-reply-to: <1339510848-16992-19-git-send-email-jack@xxxxxxx>
References: <1339510848-16992-1-git-send-email-jack@xxxxxxx> <1339510848-16992-19-git-send-email-jack@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +      * We will pass freeze protection with a transaction.  So tell lockdep
> +      * we released it.
> +      */
> +     
> rwsem_release(&ioend->io_inode->i_sb->s_writers.lock_map[SB_FREEZE_FS-1],
> +                   1, _THIS_IP_);

I'll need some time to get through the whole series, but repeated use
of constructs like this really screams for a helper abstracting it out
and documenting it.

<Prev in Thread] Current Thread [Next in Thread>