xfs
[Top] [All Lists]

[PATCH] xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: fix allocbt cursor leak in xfs_alloc_ag_vextent_near
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Jun 2012 14:20:26 +1000
From: Dave Chinner <dchinner@xxxxxxxxxx>

When we fail to find an matching extent near the requested extent
specification during a left-right distance search in
xfs_alloc_ag_vextent_near, we fail to free the original cursor that
we used to look up the XFS_BTNUM_CNT tree and hence leak it.

Reported-by: Chris J Arges <chris.j.arges@xxxxxxxxxxxxx>
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 fs/xfs/xfs_alloc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index 229641f..70878aa 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -1080,6 +1080,7 @@ restart:
                        goto restart;
                }
 
+               xfs_btree_del_cursor(cnt_cur, XFS_BTREE_NOERROR);
                trace_xfs_alloc_size_neither(args);
                args->agbno = NULLAGBLOCK;
                return 0;
-- 
1.7.10

<Prev in Thread] Current Thread [Next in Thread>