[Top] [All Lists]

Re: [PATCH] xfs: check for stale inode before acquiring iflock on push

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs: check for stale inode before acquiring iflock on push
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Jun 2012 10:18:55 +1000
Cc: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4FD63B60.3070708@xxxxxxx>
References: <1339425583-54949-1-git-send-email-bfoster@xxxxxxxxxx> <4FD63B60.3070708@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jun 11, 2012 at 01:39:28PM -0500, Mark Tinguely wrote:
> On 06/11/12 09:39, Brian Foster wrote:
> >An inode in the AIL can be flush locked and marked stale if
> >a cluster free transaction occurs at the right time. The
> >inode item is then marked as flushing, which causes xfsaild
> >to spin and leaves the filesystem stalled. This is
> >reproduced by running xfstests 273 in a loop for an
> >extended period of time.
> >
> >Check for stale inodes before the flush lock. This marks
> >the inode as pinned, leads to a log flush and allows the
> >filesystem to proceed.
> >
> >Signed-off-by: Brian Foster<bfoster@xxxxxxxxxx>
> >---
> >
> >This patch resolves the stall I was reproducing with the 273 loop test.
> >I repeated the test pretty much throughout the weekend. I still hit one
> >hung task timeout message, but the test proceeded through it.
> >
> >Dave, I know you mentioned you were sending a similar patch. Either you
> >didn't get to it or I missed it, but here's what I've been testing....
> >
> >Brian
> >
> Still hangs right away on Linux 3.5rc1 using a very small log and
> the perl test program.
> I will investigate more.
> Darn, the printk routines in Linux 3.5 added a "struct log" and
> crash is finding that definition.

Luckily that's just an internal structure in printk.c. However, I've
been waiting for such a namespace collision to happen for a long
time so perhaps you could write a patch that renames the XFS one to
"struct xlog" to match all the other XFS log codei to avoid
potential problems in the future. Oh, and while you are there, kill
the xlog_t typedef....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>