[Top] [All Lists]

Re: Re: [PATCH] Printk for ENOSPC due to lack of inodes

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: Re: [PATCH] Printk for ENOSPC due to lack of inodes
From: Raghavendra D Prabhu <raghu.prabhu13@xxxxxxxxx>
Date: Fri, 1 Jun 2012 11:37:02 +0530
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :x-operating-system:x-editor:user-agent; bh=m43LG2uEScnMQrAvKeR9pWcf4h6CtDrdf7AzHDVAQz0=; b=YH3rMcPrQoM7LmWvXKGtLJj16odBGO3Pg9rkZG6QJz192rpB+C9jBXsGcqhM2Y//UD IWcMDX/YNbO7uYLVDGoO5AAQFaVlZ2GYzrVFWL3s4eIzy/oy9t9zmN7VhseSNiYal/X2 bg+s+uAQJ9oq3PPvwGsyyhpJ63GOA3fI5m/++wQNe/VsrqwAlrFgjiVgCEnNTiswmPXM Ron/qBpAwKKNChnqhwySSr4oG45kvcAXs9cXf+sC1/sn51nqtywSHZCFdcHmZYufnHHn Rpz3UR+p9J+Bmu2fQD3NW9/YpCYAOUvGVS91RZ/4mqQ/+iwNtxllOx5t4a3NloQunptN uAbQ==
In-reply-to: <4FC83789.8010900@xxxxxxxxxxx>
Mail-followup-to: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20120227003733.GA28162@Xye> <4F579D4C.4040208@xxxxxxxxxxx> <20120531193616.GA3953@xxxxxxxxx> <4FC83789.8010900@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)

* On Thu, May 31, 2012 at 10:31:21PM -0500, Eric Sandeen <sandeen@xxxxxxxxxxx> 
On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:

Thanks for the review. I have now moved it inside xfs_dialloc. Along with 
adding the message, I noticed that the loop

    while (!agi->agi_freecount) {

is redundant when noroom=1 and okalloc=0.

Also, xfs_ialloc_ag_alloc function in the loop calls
    if (mp->m_maxicount &&
        mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {


condition again.

So I have moved xfs_tran_brelse etc. into the condition along with message.

Is this logic valid? If it is, then I will look into rate-limiting the message 

It'd be easiest to understand this new change as a patch rather than as a 
Yeah, I would certainly send it as a patch. This was just for RFC. :)

If you are changing logic or flow in addition to adding the messages, it should 
almost certainly be sent as more than one patch.
Thanks, I will make it so.



xfs mailing list

Raghavendra Prabhu
GPG Id : 0xD72BE977
Fingerprint: B93F EBCB 8E05 7039 CD3C A4B8 A616 DCA1 D72B E977
www: wnohang.net

Attachment: pgpQPwnbQPu8M.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>