xfs
[Top] [All Lists]

Re: Re: [PATCH] Printk for ENOSPC due to lack of inodes

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: Re: [PATCH] Printk for ENOSPC due to lack of inodes
From: Raghavendra D Prabhu <raghu.prabhu13@xxxxxxxxx>
Date: Fri, 1 Jun 2012 01:06:16 +0530
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :x-operating-system:x-editor:user-agent; bh=0IwWShEHfvtj0UrR4d8+dPBw/0MnySRvkFAJia8kVoo=; b=RSxmRYOgR3Iez0LZDTVg6WATzKCjvbVzLXDYxNwIwNpFdMoqYn9OUIfoaa6qfSnmvd 5kRvRBWBAkuW9Y2nNi3munmEq9HXq7xoFX2TgZ4ZaBBxIVZ1QYNHlJuQq2e6+7POSKZL /I2QvSzi0URFXgL4W6+gywwrCoAe+IzcuE6PKFVTN5fUiey87LKsGWegQKCvoP5DyKk4 2BxJZeLDJMHpnEbCCKPDplwEMQlxngjeN5tQtY6n8bMOxVCclgS2+N/96tp5gBvpErjt RjdEyjr8TToueiJDkW1OzoEqlxlAXUFfEYgGEajfnXlFoqSN6xop0hlQT7JUdUJ6JJK1 z34Q==
In-reply-to: <4F579D4C.4040208@xxxxxxxxxxx>
Mail-followup-to: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20120227003733.GA28162@Xye> <4F579D4C.4040208@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
Hi,

Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop

        while (!agi->agi_freecount) {
        }

is redundant when noroom=1 and okalloc=0.

Also, xfs_ialloc_ag_alloc function in the loop calls
============
        if (mp->m_maxicount &&
            mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {

===============

condition again.

So I have moved xfs_tran_brelse etc. into the condition along with message.

Is this logic valid? If it is, then I will look into rate-limiting the message etc.
* On Wed, Mar 07, 2012 at 11:39:24AM -0600, Eric Sandeen <sandeen@xxxxxxxxxxx> 
wrote:
On 2/26/12 6:37 PM, Raghavendra D Prabhu wrote:
Hi,

While diagnosing a MySQL crash (on a Centos 5.7 box), I noticed that
it had failed with ENOSPC earlier; it was rebooted after that; now
after reboot, even though space was there, ENOSPC was showing up, I
also did df -i and it showed inodes available. At this point,
mounting with inode64 option was tried, which fixed it.
http://oss.sgi.com/archives/xfs/2011-03/msg00299.html helped me
here.

Yeah, that's kind of a bummer.  And given the semi-ugly situation
we're in with inode32, maybe a syslog message would be good.

But a few things; I don't think we want to warn on every inode-allocation
ENOSPC.  Ideally I'd probably do a WARN_ON_ONCE or a ratelimited printk.
xfs_warn_once_per_fs()?  :)

I'd probably also want to only do it in the case where the ENOSPC was due
to either inode32, or due to fragmented freespace.

Without looking very hard yet; could this be done in xfs_dialloc() so that
the exact reason for the ENOSPC can be issued?  (maxicount, inode32, or
no free contiguous space...)

-Eric


So, I have attached a patch here.

=====================================================================


When a ENOSPC is encountered and it is due to lack of inodes (particularly
without inode64), it is not possible to detect this (df -i doesn't help here),
so adding a printk which can aid in detecting this.

Signed-off-by: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
---
 fs/xfs/xfs_qm.c       |    3 +++
 fs/xfs/xfs_vnodeops.c |   10 ++++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
index c872fea..fbefa87 100644
--- a/fs/xfs/xfs_qm.c
+++ b/fs/xfs/xfs_qm.c
@@ -987,6 +987,9 @@ xfs_qm_qino_alloc(

     error = xfs_dir_ialloc(&tp, NULL, S_IFREG, 1, 0, 0, 1, ip, &committed);
     if (error) {
+        if (error == ENOSPC)
+            xfs_err(mp, "Out of inodes: Required %d, Current %llu, Maximum 
%llu",
+                    XFS_IALLOC_INODES(mp), mp->m_sb.sb_icount, 
mp->m_maxicount);
         xfs_trans_cancel(tp, XFS_TRANS_RELEASE_LOG_RES |
                  XFS_TRANS_ABORT);
         return error;
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c
index ebdb888..7542c36 100644
--- a/fs/xfs/xfs_vnodeops.c
+++ b/fs/xfs/xfs_vnodeops.c
@@ -946,8 +946,11 @@ xfs_create(
     error = xfs_dir_ialloc(&tp, dp, mode, is_dir ? 2 : 1, rdev,
                    prid, resblks > 0, &ip, &committed);
     if (error) {
-        if (error == ENOSPC)
+        if (error == ENOSPC) {
+            xfs_err(mp, "Out of inodes: Required %d, Current %llu, Maximum 
%llu",
+                    XFS_IALLOC_INODES(mp), mp->m_sb.sb_icount, 
mp->m_maxicount);
             goto out_trans_cancel;
+        }
         goto out_trans_abort;
     }

@@ -1610,8 +1613,11 @@ xfs_symlink(
     error = xfs_dir_ialloc(&tp, dp, S_IFLNK | (mode & ~S_IFMT), 1, 0,
                    prid, resblks > 0, &ip, NULL);
     if (error) {
-        if (error == ENOSPC)
+        if (error == ENOSPC) {
+            xfs_err(mp, "Out of inodes: Required %d, Current %llu, Maximum 
%llu",
+                    XFS_IALLOC_INODES(mp), mp->m_sb.sb_icount, 
mp->m_maxicount);
             goto error_return;
+        }
         goto error1;
     }



_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs





Regards,
--
Raghavendra Prabhu
GPG Id : 0xD72BE977
Fingerprint: B93F EBCB 8E05 7039 CD3C A4B8 A616 DCA1 D72B E977
www: wnohang.net

Attachment: pgpGWugXb0NmN.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>