Re: [PATCH] xfs: shutdown xfs_sync

xfs

Re: [PATCH] xfs: shutdown xfs_sync_worker before the log

To:	Ben Myers <bpm@xxxxxxx>
Subject:	Re: [PATCH] xfs: shutdown xfs_sync_worker before the log
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Thu, 31 May 2012 11:23:25 -0500
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20120525204536.GA4721@xxxxxxx>
References:	<20120323174327.GU7762@xxxxxxx> <20120514203449.GE16099@xxxxxxx> <20120516015626.GN25351@dastard> <20120516170402.GD3963@xxxxxxx> <20120517071658.GP25351@dastard> <20120524223952.GU16099@xxxxxxx> <20120525204536.GA4721@xxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 05/25/12 15:45, Ben Myers wrote:

xfs:  shutdown xfs_sync_worker before the log

Revert commit 1307bbd, which uses the s_umount semaphore to provide
exclusion between xfs_sync_worker and unmount, in favor of shutting down
the sync worker before freeing the log in xfs_log_unmount.  This is a
cleaner way of resolving the race between xfs_sync_worker and unmount
than using s_umount.

Index: xfs/fs/xfs/xfs_log.c


Waiting for the worker to end before destroying the AIL looks like a
better solution.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker, (continued) Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker, Ben Myers Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker, Dave Chinner Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker, Dave Chinner Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker, Ben Myers Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker, Ben Myers [PATCH] xfs: shutdown xfs_sync_worker before the log, Ben Myers Re: [PATCH] xfs: shutdown xfs_sync_worker before the log, Ben Myers Re: [PATCH] xfs: shutdown xfs_sync_worker before the log, Brian Foster Re: [PATCH] xfs: shutdown xfs_sync_worker before the log, Ben Myers Re: [PATCH] xfs: shutdown xfs_sync_worker before the log, Brian Foster Re: [PATCH] xfs: shutdown xfs_sync_worker before the log, Mark Tinguely <=

Previous by Date:	Fw: Attention: Email Account Holder, UK National Lottery
Next by Date:	Re: [PATCH 1/2] types.h: implement intptr_t and uintptr_t, Ben Myers
Previous by Thread:	Re: [PATCH] xfs: shutdown xfs_sync_worker before the log, Brian Foster
Next by Thread:	git://oss.sgi.com/xfs/xfs master branch rebase, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]