xfs
[Top] [All Lists]

Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more v

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 29 May 2012 11:54:31 -0500
Cc: Boris Ranto <branto@xxxxxxxxxx>, xfs <xfs@xxxxxxxxxxx>
In-reply-to: <20111028095354.GA1062@xxxxxxxxxxxxx>
References: <1319625983.3074.28.camel@xxxxxxxxxxxxxxxxxxxxxxxxxx> <be02ada1-aee5-406d-84cd-d54dde7ae871@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20111028095354.GA1062@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
On 10/28/11 4:53 AM, Christoph Hellwig wrote:
> On Fri, Oct 28, 2011 at 05:38:06AM -0400, Boris Ranto wrote:
>> The test 016 fills scratch device with some data and then creates xfs fs
>> on the scratch device. Later, the test assumes that the previously
>> written data are still written there and checks for them at specific
>> locations. On ssd drive this will lead to a failure since the blocks are
>> discarded by default when the mkfs command is run.
>> This is a more verbose version of the previous patch.
>> This simple patch that adds -K to stop the discarding (if the mkfs
>> command supports it) fixed the issue for me:
>>
>> Signed-off-by: Boris Ranto <branto@xxxxxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Seems this one got lost; we should still merge it, yes?

-Eric

<Prev in Thread] Current Thread [Next in Thread>