Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 10/28/11 4:53 AM, Christoph Hellwig wrote:
> On Fri, Oct 28, 2011 at 05:38:06AM -0400, Boris Ranto wrote:
>> The test 016 fills scratch device with some data and then creates xfs fs
>> on the scratch device. Later, the test assumes that the previously
>> written data are still written there and checks for them at specific
>> locations. On ssd drive this will lead to a failure since the blocks are
>> discarded by default when the mkfs command is run.
>> This is a more verbose version of the previous patch.
>> This simple patch that adds -K to stop the discarding (if the mkfs
>> command supports it) fixed the issue for me:
>>
>> Signed-off-by: Boris Ranto <branto@xxxxxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Seems this one got lost; we should still merge it, yes?

-Eric