xfs
[Top] [All Lists]

Re: Still seeing hangs in xlog_grant_log_space

To: Peter Watkins <treestem@xxxxxxxxx>
Subject: Re: Still seeing hangs in xlog_grant_log_space
From: Juerg Haefliger <juergh@xxxxxxxxx>
Date: Fri, 25 May 2012 08:28:10 +0200
Cc: bpm@xxxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=OmBdpJWm5RxKKYC3KFzEKBvvgyJGSpQmYrmLKqO+OCk=; b=Q26p72P/VsBHH2WKmUKZfb0w2gQxH3i+6YbpupOHf2AZytvQuYYRI1xKdrScesMw7Y RzxOLDzmq97bA71R3osD91N4BwSCdYGCzHicJxZ+0AmgMB68jdLVM1yJXtXW9BATYsIH Zyw9EPzKCIbRcYQ0SKS+JIroUuZ1U5EC8Y5dlu6vQlxn9FSrdWX4BSMJRdBK2vGhLywI iuZGzpvFRC6ihuH36/18hEYEu0hwJv3j4iBBhzU5LjgyodT6jBOgQGwSPzP+4AsbBF2e T3KVske/jnsOxkX7xAyH3ILKi6syZlHYsONZ3SelZYPDfjJGCrEZBW1CemWBZe2maTwM 3cjw==
In-reply-to: <CAH4wwdGWHSZoveLJMxu5pjr22NEEeW7oG8TS+snoM8RY=ZeRmg@xxxxxxxxxxxxxx>
References: <CAH4wwdGWHSZoveLJMxu5pjr22NEEeW7oG8TS+snoM8RY=ZeRmg@xxxxxxxxxxxxxx>
> Does your kernel have the effect of
>
> 0bf6a5bd4b55b466964ead6fa566d8f346a828ee xfs: convert the xfsaild
> thread to a workqueue

No.


> c7eead1e118fb7e34ee8f5063c3c090c054c3820 xfs: revert to using a
> kthread for AIL pushing

No.


> In particular, is this code in xfs_trans_ail_push:
>
>       smp_wmb();
>       xfs_trans_ail_copy_lsn(ailp, &ailp->xa_target, &threshold_lsn);
>       smp_wmb();

No. xfs_trans_ail_push looks like this:

void
xfs_trans_ail_push(
        struct xfs_ail  *ailp,
        xfs_lsn_t       threshold_lsn)
{
        xfs_log_item_t  *lip;

        lip = xfs_ail_min(ailp);
        if (lip && !XFS_FORCED_SHUTDOWN(ailp->xa_mount)) {
                if (XFS_LSN_CMP(threshold_lsn, ailp->xa_target) > 0)
                        xfsaild_wakeup(ailp, threshold_lsn);
        }
}


FWIW, the XFS driver in my kernel is identical to the vanilla 2.6.38
driver. I'm still trying to get a XFS trace from a production hang. I
do have a crash dump from a production machine with /tmp hanging.
Would it be helpful to share that dump?

...Juerg

<Prev in Thread] Current Thread [Next in Thread>