xfs
[Top] [All Lists]

Re: [PATCH] Fix failure in 273 due to lack of inodes

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH] Fix failure in 273 due to lack of inodes
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 15 May 2012 15:27:22 -0500
Cc: xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx
In-reply-to: <1337113229-9714-1-git-send-email-jack@xxxxxxx>
References: <1337113229-9714-1-git-send-email-jack@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
On 5/15/12 3:20 PM, Jan Kara wrote:
> Test 273 fails for me due to lack of inodes (ext? filesystem is not configured
> to have enough inodes for being filled up by 4k files). So change the test
> to create larger files so that we don't hit this limit.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---
>  273 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
>  I'm not sure if this fix isn't also just lurking somewhere in the pipeline
> but I didn't find anything...
> 
> diff --git a/273 b/273
> index 2965132..0bf7167 100755
> --- a/273
> +++ b/273
> @@ -43,7 +43,7 @@ _cleanup()
>  . ./common.filter
>  
>  threads=50
> -count=1
> +count=2
>  
>  _threads_set()
>  {

It seems harmless; I never quite knew what this test was testing, so I can't 
say whether or not it breaks the purpose of the test ;)

I'll give it a 

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

and (try to remember to) merge it in a bit, if nobody speaks up against it.

-Eric

<Prev in Thread] Current Thread [Next in Thread>