xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: hole-punch use truncate_pagecache_range

To: Hugh Dickins <hughd@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: hole-punch use truncate_pagecache_range
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 15 May 2012 02:57:18 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <alpine.LSU.2.00.1205131347120.1547@xxxxxxxxxxxx>
References: <alpine.LSU.2.00.1205131347120.1547@xxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, May 13, 2012 at 01:50:06PM -0700, Hugh Dickins wrote:
> When truncating a file, we unmap pages from userspace first, as that's
> usually more efficient than relying, page by page, on the fallback in
> truncate_inode_page() - particularly if the file is mapped many times.
> 
> Do the same when punching a hole: 3.4 added truncate_pagecache_range()
> to do the unmap and trunc, so use it in xfs_flushinval_pages(), instead
> of calling truncate_inode_pages_range() directly.

This change looks fine.

> Should xfs_tosspages() be using it too?  I don't know: left unchanged.

I'll look at it.  I've been planning to simplify and/or kill the
xfs_fs_subr.c wrappers which tend to confuse the code for a while now,
and deciding what exactly to do should be a fallout from that.

<Prev in Thread] Current Thread [Next in Thread>