xfs
[Top] [All Lists]

Re: [PATCH v2 2/2] xfstests: introduce 280 for SEEK_DATA/SEEK_HOLE copy

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH v2 2/2] xfstests: introduce 280 for SEEK_DATA/SEEK_HOLE copy check
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Tue, 15 May 2012 12:47:13 +0800
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4FAD2D18.20403@xxxxxxx>
Organization: Oracle
References: <4F2FE410.2040508@xxxxxxxxxx> <4FAD2D18.20403@xxxxxxx>
Reply-to: jeff.liu@xxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20
Hi Rich,

Sorry for my late response!

On 05/11/2012 11:15 PM, Rich Johnston wrote:

> 
> On 02/06/2012 08:30 AM, Jeff Liu wrote:
>> Introduce 280 for SEEK_DATA/SEEK_HOLE copy check.
>>
>> Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
>>
> 
> 
> 
>> +static int
>> +do_extent_copy(int src_fd, int dest_fd, off_t data_off, off_t hole_off)
>> +{
> 
> ...
> 
>> +
>> +    while (len>  0) {
>> +        memset(buf, 0, sizeof(buf));
>> +        ssize_t nr_read = read(src_fd, buf, BUF_SIZE);
> #RCJ The memset above is unnecessary.
> 
> 
>> +static int
>> +copy_extents(int src_fd, int dest_fd, off_t src_total_size)
>> +{
>> +    int ret = 0;
>> +    unsigned int i = 0;
> 
> ...
> 
>> +        ++i;
>> +        seek_start = hole_pos;
>> +    } while (seek_start<  src_total_size);
> #RCJ i is unused.

Thanks for the review, I'll fix them later.

-Jeff

> 
> Other than the comments above, this version of the test looks good.
> Reviewed-by: Rich Johnston<rjohnston@xxxxxxx>
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>