xfs
[Top] [All Lists]

Re: [PATCH v3 1/2] xfstests: introduce 279 for SEEK_DATA/SEEK_HOLE sanit

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v3 1/2] xfstests: introduce 279 for SEEK_DATA/SEEK_HOLE sanity test
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 10 May 2012 15:28:10 -0500
Cc: xfs@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <4F410ABF.7070001@xxxxxxxxxx>
References: <4F410ABF.7070001@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Feb 19, 2012 at 10:44:15PM +0800, Jeff Liu wrote:
> Introduce 279 for SEEK_DATA/SEEK_HOLE sanity tests.
> 
> Changes to v3:
> --------------
> * Redirect seek sanity test run log to 279.full.
> 
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>

...

> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> new file mode 100644
> index 0000000..8f36dee
> --- /dev/null
> +++ b/src/seek_sanity_test.c
> @@ -0,0 +1,683 @@

...

> +static void get_file_system(int fd)
> +{
> +     struct statfs buf;
> +
> +     if (!fstatfs(fd, &buf))
> +             fprintf(stdout, "File system magic#: 0x%x\n", buf.f_type);

Hrm...

# make
Building include
Building lib
Building ltp
Building src
[DEP]
[CC]    seek_sanity_test
seek_sanity_test.c: In function 'get_file_system':
seek_sanity_test.c:46: warning: format '%x' expects type 'unsigned int', but 
argument 3 has type 'long int'
Building aio-dio-regress
Building m4

I'll fix that up for you.

<Prev in Thread] Current Thread [Next in Thread>